This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove v0 node-side parachains code #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
coriolinus
approved these changes
Aug 18, 2020
5 tasks
|
is the burnin happening? (needs rebasing) |
|
@gavofyork Yeah, it has burned in on Westend and Kusama correctly. |
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the following crates:
polkadot-validation still remains as a simple stub that provides an empty set of candidates for inclusion in the set-heads inherent. Although v0 parachains runtime code was removed in #1501, there are still live networks (Polkadot, Kusama, Westend) which have it deployed, and they will require the set-heads inherent in order to proceed until a runtime upgrade enacts the removal on those networks.
At that point, we will be able to remove the polkadot-validation and polkadot-service crates entirely, replacing with v1 code.